Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused errors and align with commonalities errors #126

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Remove unused errors and align with commonalities errors #126

merged 2 commits into from
Jul 19, 2024

Conversation

fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

  1. Error 409 -> removed since it doesn¡t have any use case
  2. Error 404 SIM_SWAP.UNKNOWN_PHONE_NUMBER -> remove from the spec and included in generic 404 NOT_FOUND
  3. Error 403 -> align with commonalities description
  4. Align the rest of the errors with commonalities model

Which issue(s) this PR fixes:

Fixes #119

@fernandopradocabrillo fernandopradocabrillo added the Fall24 Fall 24 release preparation label Jul 17, 2024
@fernandopradocabrillo fernandopradocabrillo self-assigned this Jul 17, 2024
bigludo7
bigludo7 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo fernandopradocabrillo merged commit 80b9b7a into camaraproject:main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

Assignees

@fernandopradocabrillo fernandopradocabrillo

Labels
Fall24 Fall 24 release preparation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit defined errors
2 participants
@fernandopradocabrillo @bigludo7