Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test plan #159

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Update test plan #159

merged 3 commits into from
Oct 18, 2024

Conversation

fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction
  • tests

What this PR does / why we need it:

  1. Includes a new test case to check the response when there is no sim swap providing maxAge and not providing it
  2. Change Given step to align with other test plans how the phoneNumber is informed
  3. Rename files to comply with commonalities guidelines
  4. Remove 403 INVALID_TOKEN_CONTEXT test case that should not be covered by this error code

Which issue(s) this PR fixes:

Fixes #154

@fernandopradocabrillo fernandopradocabrillo self-assigned this Oct 17, 2024
@fernandopradocabrillo fernandopradocabrillo added the Spring25 Spring25 release preparation label Oct 17, 2024
bigludo7
bigludo7 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me

@bigludo7 bigludo7 added Fall24 Fall 24 release preparation and removed Spring25 Spring25 release preparation labels Oct 18, 2024
@fernandopradocabrillo fernandopradocabrillo merged commit fc25875 into camaraproject:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

Assignees

@fernandopradocabrillo fernandopradocabrillo

Labels
Fall24 Fall 24 release preparation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with @check_sim_swap_6_no_sim_swap scenario
2 participants
@fernandopradocabrillo @bigludo7