Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines alignment errors and camel case #20

Conversation

monamok
Copy link
Collaborator

@monamok monamok commented Mar 29, 2023

This PR will handle issue#21

The modified parts are just the errors and parmeters but for some reason I was not able to avoid GIT from showing deleting and readding the same lines. Here you can find the diffrences.

I renamed the file as the version was hard coded in the name and it's not valid anymore.

cc: @jlurien

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and look good for me !
Thanks

@monamok
Copy link
Collaborator Author

monamok commented Mar 30, 2023

Dear @DT-DawidWroblewski could you please take a look and if it's ok go ahead and merge it?
Thank you.

Copy link
Collaborator

@DT-DawidWroblewski DT-DawidWroblewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DT-DawidWroblewski DT-DawidWroblewski merged commit 4ec0449 into camaraproject:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants