Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dot from end of SIM_SWAP.UNKNOWN_PHONE_NUMBER response message. This is to align with other response messages. #62

Conversation

trehman-gsma
Copy link
Collaborator

@trehman-gsma trehman-gsma commented Oct 13, 2023

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

This is a tiny change! Removing only 1 character from the spec.

Have removed the dot at the end of the message for SIM_SWAP.UNKNOWN_PHONE_NUMBER.

i.e. "SIM Swap can't be checked because the phone number is unknown." has been changed to "SIM Swap can't be checked because the phone number is unknown" (notice that the dot is removed at the end of the message).

This is simply to align the SIM_SWAP.UNKNOWN_PHONE_NUMBER message with the other non-200 response messages. They all lack the dot at the end of the message. For example, "Client does not have sufficient permissions to perform this action"

Which issue(s) this PR fixes:

I did not create an issue for this - it seemed too small to raise an issue for. I can raise one if required.

Special notes for reviewers:

I was reviewing the existing spec in context of GSMA certification/testing and noticed the discrepancy.

Changelog input

 release-note

The message value in the 404 SIM_SWAP.UNKNOWN_PHONE_NUMBER response has been slightly amended to remove a trailing dot/period. This is to align with the other non-200 response messages (they do not have trailing dot/periods). 

Additional documentation

N/A

…h the other error messages (they lack the dot).
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DT-DawidWroblewski DT-DawidWroblewski merged commit fc98720 into camaraproject:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants