Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #9

Merged
merged 31 commits into from
Dec 30, 2022
Merged

Add files via upload #9

merged 31 commits into from
Dec 30, 2022

Conversation

bigludo7
Copy link
Collaborator

Added API documentation for the 2-endpoints SIM Swap API

Added API documentation for the 2-endpoints SIM Swap API
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions and feel free to accept or comment. Thanks for providing this

documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
bigludo7 and others added 24 commits December 27, 2022 14:03
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Changes ISV (Independent Software Provider) to SP
Copy link
Collaborator Author

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed ISV to SP

Fixed API documentation accordingly to @monamok & @jlurien review (Thanks for this review)
Copy link
Collaborator Author

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed API documentation accordingly to @monamok & @jlurien review (Thanks for this review)

monamok
monamok previously approved these changes Dec 28, 2022
Copy link
Collaborator

@monamok monamok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small coments but it looks good.

documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
documentation/API_documentation/Check_sim_swap_API.md Outdated Show resolved Hide resolved
bigludo7 and others added 3 commits December 28, 2022 11:58
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Fixed ### 4.4 Policies formatting.
Copy link
Collaborator Author

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ### 4.4 Policies formatting.

@bigludo7
Copy link
Collaborator Author

Thanks @monamok for this final review.
@DT-DawidWroblewski up to you for review. Thanks

@monamok
Copy link
Collaborator

monamok commented Dec 28, 2022

Fixed ### 4.4 Policies formatting.

@bigludo7 please check ### 4.3 Errors too.

Fixing formatting
Copy link
Collaborator Author

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing formatting.

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator Author

@DT-DawidWroblewski Now that the swagger is merged could you please review and/or approve the PR for the documentation.
Thanks.

@DT-DawidWroblewski DT-DawidWroblewski merged commit b0af1f6 into main Dec 30, 2022
@bigludo7 bigludo7 deleted the bigludo7-patch-3 branch December 30, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants