Stop AAAuthService overwriting logout service URL #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging default configuration settings in apply_config_defaults(), the value that should be set by 'AALogoutService' (specifying a URL to which the user can be directed to log out of the central authentication service) will be clobbered if a custom 'AAAuthService' has also been specified in configuration. This is due to a typo. The end result is that the AALogoutService directive is useless (even the default value will be blown away) if AAAuthService is specified. This bug has probably never been discovered to date, because (almost) nobody uses a service that isn't production Raven, whose auth service and logout URLs are is hard-coded as defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging default configuration settings in apply_config_defaults(), the value that should be set by 'AALogoutService' (specifying a URL to which the user can be directed to log out of the central authentication service) will be clobbered if a custom 'AAAuthService' has also been
specified in configuration. This is due to a typo.
The end result is that the AALogoutService directive is useless (even the default value will be blown away) if AAAuthService is specified.
This bug has probably never been discovered to date, because (almost) nobody uses a service that isn't production Raven, whose auth service and logout URLs are hard-coded as defaults.