-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Alpaca pydantic class for easy conversion, validation, and structured output generation #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caelum Forder <caelum119@gmail.com>
Signed-off-by: Caelum Forder <caelum119@gmail.com>
Signed-off-by: Caelum Forder <caelum119@gmail.com>
Wendong-Fan
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CaelumF , could you help resolve the conflict with master branch?
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com>
Wendong-Fan
changed the title
Alpaca pydantic class for easy conversion, validation, and structured output generation
feat: Alpaca pydantic class for easy conversion, validation, and structured output generation
Dec 2, 2024
Wendong-Fan
reviewed
Dec 2, 2024
Wendong-Fan
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an alpaca pydantic class that allows for conversion to/from the Alpaca inference/training textual representation, and through pydantic, to/from json representations.
The expected way to generate this is however through structured output, though the other methods are useful for inference, training, and combining existing items from other sources.
Motivation and Context
Possibly closes #1184, though it doesn't provide a discoverable way to do this unless people are already familiar with Pydantic. Potentially a 1-liner function can be added to BaseMessage that shows how the
message
string can be easily converted, or maybe we do not need this to be particularly discoverable through the code APIs, if a larger theme of relying on pydantic classes for conversion is established as a recognisable pattern.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!