Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate stripe #1261

Merged
merged 18 commits into from
Dec 13, 2024
Merged

feat: Integrate stripe #1261

merged 18 commits into from
Dec 13, 2024

Conversation

pointearth
Copy link
Collaborator

@pointearth pointearth commented Dec 2, 2024

Description

#1186
Add camel/toolkits/stripe_toolkit.py

Motivation and Context

  • Add stripe toolkit
  • Need to be checked if the solution fit expected design

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New feature (stripe support, including some read-only functions as the first step)
  • Documentation (update in the documentation)
  • Unit Tests

Implemented Tasks

  • CustomerAdapter (get_customer, list_customers)
  • BalanceAdapter (get_balance,list_balance_transactions)
  • PaymentAdapter (get_payment, list_payments)
  • RefundAdapter (get_refund, list_refunds)
  • Aggregate functions into the class StripeToolkit
  • Provide a base class StripeBaseAdapter to wrap base functions for Adapters
  • .env
  • pyproject.toml

Checklist

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@NeilJohnson0930
Copy link
Collaborator

Great work on the code so far! Have you considered adding a verification step for conversations between humans and agents to ensure security when using the transaction function?

@Wendong-Fan Wendong-Fan added this to the Sprint 17 milestone Dec 2, 2024
@Wendong-Fan Wendong-Fan linked an issue Dec 2, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan changed the title stripe_toolkit.py without unit tests feat: stripe_toolkit.py without unit tests Dec 2, 2024
@pointearth pointearth marked this pull request as ready for review December 5, 2024 00:05
@pointearth pointearth closed this Dec 5, 2024
@pointearth pointearth reopened this Dec 5, 2024
@pointearth pointearth enabled auto-merge (squash) December 6, 2024 22:46
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pointearth and sorry for the late review, left some comments below and added one more commit here 9aac0cd based on the comment, please feel free to review the change, currently there's one error error: Module "stripe.error" has no attribute "StripeError", which also lead the unit test not passing, could you help check this part further? Thanks!

camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/__init__.py Show resolved Hide resolved
camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/stripe_toolkit.py Outdated Show resolved Hide resolved
@Wendong-Fan Wendong-Fan changed the title feat: stripe_toolkit.py without unit tests feat: Integrate stripe Dec 11, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pointearth ! LGTM

@Wendong-Fan Wendong-Fan disabled auto-merge December 13, 2024 00:26
@Wendong-Fan Wendong-Fan merged commit 7d9c906 into master Dec 13, 2024
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the feature/stripe branch December 13, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate Stripe to use financial services with agents
3 participants