feat: Update slack_bot #1353
feat: Update slack_bot #1353
Conversation
|
Thanks @Wendong-Fan, The related issue has been fixed. |
There was a problem hiding this comment.
Thanks @Asher-hss , just curious, I guess you created a new slack socket mode bot, but in the new socket mode bot, you did the work of being compatible with socket mode and http mode. Why not just do what the socket mode should do in the slack socket mode bot?
camel/bots/slack/slack_app.py
Outdated
| scopes: Optional[str] = None, | ||
| signing_secret: Optional[str] = None, | ||
| client_id: Optional[str] = None, | ||
| client_secret: Optional[str] = None, | ||
| redirect_uri_path: str = "/slack/oauth_redirect", | ||
| installation_store: Optional[AsyncInstallationStore] = None, | ||
| socket_mode: bool = True, |
There was a problem hiding this comment.
Hi @Asher-hss , when we create a new slack app, socket mode is turned off by default. Let's set socket_mode to False to maintain consistency with the official configuration.
| self._handler: Optional[ | ||
| Union[AsyncSlackRequestHandler, AsyncSocketModeHandler] | ||
| ] = None | ||
| if not self.socket_mode: |
There was a problem hiding this comment.
Hi @Asher-hss , the slack app contains OAuth verification and Message communication. In socket mode, the OAuth process also needs to be allowed. I don't think the verification here is appropriate.
There was a problem hiding this comment.
The purpose here is:
- Different modes correspond to different validation procedures to avoid confusion in validation.
- Use default validation in socket mode to reduce the learning curve for users.
Hi Coco，I didn't understand what you meant. Could you explain it more clearly? |
|
pre commit, conflict with master branch, pytest need to be fixed @Asher-hss |
Description
close #slack
Motivation and Context
close #slack
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!