Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Linkup intergrate #1368

Merged
merged 8 commits into from
Dec 29, 2024
Merged

feat: Linkup intergrate #1368

merged 8 commits into from
Dec 29, 2024

Conversation

raywhoelse
Copy link
Collaborator

@raywhoelse raywhoelse commented Dec 28, 2024

Description

Describe your changes in detail.

Motivation and Context

close #1345

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan added this to the Sprint 19 milestone Dec 28, 2024
@Wendong-Fan Wendong-Fan linked an issue Dec 28, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan changed the title Linkup intergrate feat: Linkup intergrate Dec 28, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @raywhoelse ! There are some minor issues with the docstring format that need to be fixed. For this search function, I feel it's not necessary to add four additional helper functions. While making the code more modular has its benefits, in this case, it adds redundancy without enough value to justify it. WDYT?

camel/toolkits/search_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/search_toolkit.py Outdated Show resolved Hide resolved
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raywhoelse , Please remember to run poetry.lock if you've updated the pyproject.toml file, also add unit test

Thanks @liuxukun2000's review, please kindly follow our Code Review Checklist when approving PRs, the check for this PR is failing. Code review approvals should be even stricter than writing code yourself. Your code undergoes review before merging, but if you approve a PR, it could be merged directly into our main branch, leaving no room for errors.

@Wendong-Fan Wendong-Fan merged commit bdb240d into master Dec 29, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the linkup_intergrate branch December 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate Linkup
4 participants