-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Linkup intergrate #1368
feat: Linkup intergrate #1368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @raywhoelse ! There are some minor issues with the docstring format that need to be fixed. For this search function, I feel it's not necessary to add four additional helper functions. While making the code more modular has its benefits, in this case, it adds redundancy without enough value to justify it. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raywhoelse , Please remember to run poetry.lock if you've updated the pyproject.toml file, also add unit test
Thanks @liuxukun2000's review, please kindly follow our Code Review Checklist when approving PRs, the check for this PR is failing. Code review approvals should be even stricter than writing code yourself. Your code undergoes review before merging, but if you approve a PR, it could be merged directly into our main branch, leaving no room for errors.
Description
Describe your changes in detail.
Motivation and Context
close #1345
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!