Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nebula graph add time label #1383

Merged
merged 4 commits into from
Jan 2, 2025
Merged

feat: nebula graph add time label #1383

merged 4 commits into from
Jan 2, 2025

Conversation

waleedalzarooni
Copy link
Collaborator

Description

I have incorporated a time dimension into the Nebula graph knowledge graph implementation. I have modified the ensure_tag_exists method, ensure_edge_type_exists, add_node, add_triplet and get_structured_schema methods to include time dimensions according to this Nebula graph documentation https://docs.nebula-graph.io/3.8.0/3.ngql-guide/3.data-types/4.date-and-time/.

Motivation and Context

I have added these changes in so that Nebula graph knowledge graphs can be used to create a financial dynamic knowledge graph as in this paper, https://arxiv.org/pdf/2407.10909.
If it fixes an open issue, please link to the issue here, #1172

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

 the commit.

I have incorporated a time dimension into the Nebula graph knowledge graph implementation. I have modified the ensure_tag_exists method, ensure_edge_type_exists, add_node, add_triplet and get_structured_schema methods to include time dimensions according to this Nebula graph documentation https://docs.nebula-graph.io/3.8.0/3.ngql-guide/3.data-types/4.date-and-time/.
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waleedalzarooni for the contribution! I believe we need to confirm whether the string for the time is validated. The time label is not meant to indicate when the tag was created but rather to serve as a property label. This label should be optional, and if the user does not provide it, this should not be set. I will add one more commit based on your work, thanks again for the contribution and happy new year!

@Wendong-Fan Wendong-Fan changed the title Waleed DKG branch feat: nebula graph add time label Dec 31, 2024
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Dec 31, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 20 milestone Dec 31, 2024
@Wendong-Fan Wendong-Fan merged commit fdc727b into master Jan 2, 2025
3 checks passed
@Wendong-Fan Wendong-Fan deleted the Waleed-DKG-branch branch January 2, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants