Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structured loader #1395

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: structured loader #1395

wants to merge 18 commits into from

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Jan 3, 2025

Description

Describe your changes in detail.

Motivation and Context

close #1325

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan changed the title Feat/structured loader feat: structured loader Jan 3, 2025
@Wendong-Fan Wendong-Fan requested a review from WHALEEYE January 6, 2025 15:32
@Wendong-Fan Wendong-Fan mentioned this pull request Jan 6, 2025
13 tasks
@Wendong-Fan Wendong-Fan requested a review from MuggleJinx January 6, 2025 15:34
@Wendong-Fan Wendong-Fan added this to the Sprint 20 milestone Jan 6, 2025
@Wendong-Fan Wendong-Fan linked an issue Jan 6, 2025 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 20, Sprint 19 Jan 6, 2025
@Wendong-Fan Wendong-Fan marked this pull request as ready for review January 6, 2025 15:36
camel/benchmarks/apibank.py Show resolved Hide resolved
camel/loaders/panda_reader.py Show resolved Hide resolved
camel/loaders/panda_reader.py Outdated Show resolved Hide resolved
Comment on lines 115 to 116
if not file_path.endswith('.csv'):
raise ValueError("Only CSV files are supported")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably use a decorator to do this checking to eliminate those similar checking codes


from camel.loaders import PandaReader

logging.disable(logging.ERROR)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't ignore the error we would get

2025-01-10 22:03:12,521 - pandasai.helpers.logger - ERROR - Failed with error: Traceback (most recent call last):
  File "/Users/enrei/Library/Caches/pypoetry/virtualenvs/camel-ai-73PBX6Dc-py3.12/lib/python3.12/site-packages/pandasai/pipelines/chat/code_execution.py", line 85, in execute
    result = self.execute_code(code_to_run, code_context)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/enrei/Library/Caches/pypoetry/virtualenvs/camel-ai-73PBX6Dc-py3.12/lib/python3.12/site-packages/pandasai/pipelines/chat/code_execution.py", line 174, in execute_code
    exec(code, environment)
  File "<string>", line 11, in <module>
  File "/Users/enrei/Library/Caches/pypoetry/virtualenvs/camel-ai-73PBX6Dc-py3.12/lib/python3.12/site-packages/pandasai/safe_libs/restricted_matplotlib.py", line 75, in __getattr__
    raise AttributeError(f"'{name}' is not allowed in RestrictedMatplotlib")
AttributeError: 'tight_layout' is not allowed in RestrictedMatplotlib

any insight for this? @liuxukun2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Structured data parsing
3 participants