Bump vscode-extension-tester from 5.2.1 to 5.5.3

[dependabot]

Bumps vscode-extension-tester from 5.2.1 to 5.5.3.

Changelog

Sourced from vscode-extension-tester's changelog.

5.5.3 (April 25 2023)

• Bump 'max' placeholder to 1.77.3 version

5.5.2 (April 04 2023)

• Remove versionInfo.browser check in Workbench
• Remove .js file existence restriction
• Use vsce API instead CLI
• Allow to consume multiple strings blob as extester cli arg
• Provide terminal.copyOnSelection as default extester vscode setting

5.5.1 (March 16 2023)

• Bump 'max' placeholder to 1.76.2 version

5.5.0 (March 15 2023)

• Compatible with VS Code 1.76.0 and 1.76.1 versions
• Bump extester inner dependencies
• Fixed #537 Can't get text from terminal view

5.4.0 (February 21 2023)

• Compatible with VS Code 1.75.0 and 1.75.1 versions
• Override WebElement.isSelected for EditorView
• Provide log warning when used vscode version differs from 'latest' version enhancement
• Fix invalid artefact screenshot path in Github Actions

5.3.0 (January 24 2023)

• Renamed default branch from 'master' to 'main'
• Fixed Werbview.switchToFrame with VS Code 1.74+ when there are several webview opened
• Bump extester inner dependencies
• Stabilized flaky CustomTreeSection > getVisibleItems tests on macOS
• Improved ExTester GH workflows
• Enabled dependabot for the repository

Commits

• a5e58e2 5.5.3
• f9d5c37 Bump 'max' placeholder to latest vscode 1.77.3 (#739)
• 10eea28 5.5.2
• 969f2a9 Upversion page-objects to 3.5.1
• c7e9634 Provide support for VS Code 1.77.0 (#727)
• 5ba5a3b Remove versionInfo.browser check in Workbench (#729)
• b1d962d Remove .js and file existence restriction (#716)
• 99ce290 Use vsce API instead CLI (#715)
• 717244a Allow to consume multiple strings blob as extester cli arg (#670)
• a429a6c Provide terminal.copyOnSelection as default extester vscode settings (#695)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[apupier]

@dependabot rebase

[apupier]

https://github.com/dependabot rebase

[unsortedhashsets]

@apupier Hi, I think it is better now
Was:
Errors Files
2 src/installer.ts:150
1 src/test/suite/versionUtils.test.ts:116
2 src/versionUtils.ts:122

Main changes (there are much more auto-formatting changes):

1. catch blocks as described here -> https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables
2. headers datatypes from string[][] to [string, string][]

[apupier]

I do not understand why an update on the dev dependency is causing compilation errors in production code. Do you have an idea?

[apupier]

In case it is not an Error, it will be swallowed and we won't have any traces.
based on the link you provided, they are providing this kind of snippet code but at first sight it seems weird.
Do you have more information to it? have you seen this practice elsewhere? Is there a specific reason to do it this way?

[unsortedhashsets]

I do not understand why an update on the dev dependency is causing compilation errors in production code. Do you have an idea?

From my point of view we do not have a difference in vscode-camelk between dev or prod version 🤔

We always build project with tsconfig.json with the same configs.

To make build only with prod features (without tests and etc.) we need to make a build with some specific tsconfig.prod.json (it is the reason of errors => we always compile everything), so I think it will be possible to make:

• npm install --prod - to install only prod dependencies
• tsc --project tsconfig.prod.json - to build without compile errors related to extra dependencies 🤔

I made a small research today, and I might be wrong.
So if @djelinek can agree with my version it would be nice 🆘

Example: if you will try to compile it after npm install --prod there will be much more errors

[unsortedhashsets]

I answer this question in reverse order:

based on the link you provided, they are providing this kind of snippet code but at first sight it seems weird.

Yes, I think so too, firstly I would like to make just a small cast to String(), but it is official documentation and I decided to make it that way

Do you have more information to it? have you seen this practice elsewhere? Is there a specific reason to do it this way?

More information you can find here in issue -> microsoft/TypeScript#36775

In case it is not an Error, it will be swallowed and we won't have any traces.

Yes, you are absolutely right here 😞
WDYT to combine official snippet with the cast to string?

let message = ""
if (error instanceof Error) {
	message = error.message;
} else {
	message = String(error);				
}
extension.shareMessageInMainOutputChannel(message);
throw new Error(message);			   

or

let message = error instanceof Error ? error.message : String(error);
extension.shareMessageInMainOutputChannel(message);
throw new Error(message);

^ With ternary already checked -> no errors

[apupier]

combining official snippet with the cast to string seems a good alternative.

For the compilation distinction, I think I understand from where it comes from. I think it is better to create a specific issue to discuss it separately. The priority is lower.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication