rustdoc: Remove some unnecessary cache parameters

Based on
rust-lang#80883 (comment).
The `tcx` parameters do seem to be used though, so I only removed the
`cache` parameters.

src/librustdoc/formats/cache.rs

@@ -303,7 +303,7 @@ impl<'a, 'tcx> DocFolder for CacheBuilder<'a, 'tcx> {
  desc,
  parent,
  parent_idx: None,
- search_type: get_index_search_type(&item, self.tcx, self.cache),
+ search_type: get_index_search_type(&item, self.tcx),
  aliases: item.attrs.get_doc_aliases(),
  });
  }

src/librustdoc/html/render/search_index.rs

@@ -42,7 +42,7 @@ crate fn build_index<'tcx>(krate: &clean::Crate, cache: &mut Cache, tcx: TyCtxt<
  desc,
  parent: Some(did),
  parent_idx: None,
- search_type: get_index_search_type(item, tcx, cache),
+ search_type: get_index_search_type(item, tcx),
  aliases: item.attrs.get_doc_aliases(),
  });
  }
@@ -194,12 +194,11 @@ crate fn build_index<'tcx>(krate: &clean::Crate, cache: &mut Cache, tcx: TyCtxt<
 crate fn get_index_search_type<'tcx>(
  item: &clean::Item,
  tcx: TyCtxt<'tcx>,
- cache: &Cache,
 ) -> Option<IndexItemFunctionType> {
  let (mut inputs, mut output) = match *item.kind {
- clean::FunctionItem(ref f) => get_all_types(&f.generics, &f.decl, tcx, cache),
- clean::MethodItem(ref m, _) => get_all_types(&m.generics, &m.decl, tcx, cache),
- clean::TyMethodItem(ref m) => get_all_types(&m.generics, &m.decl, tcx, cache),
+ clean::FunctionItem(ref f) => get_all_types(&f.generics, &f.decl, tcx),
+ clean::MethodItem(ref m, _) => get_all_types(&m.generics, &m.decl, tcx),
+ clean::TyMethodItem(ref m) => get_all_types(&m.generics, &m.decl, tcx),
  _ => return None,
  };
 
@@ -254,14 +253,12 @@ crate fn get_real_types<'tcx>(
  tcx: TyCtxt<'tcx>,
  recurse: usize,
  res: &mut Vec<TypeWithKind>,
- cache: &Cache,
 ) {
  fn insert_ty(
  res: &mut Vec<TypeWithKind>,
  tcx: TyCtxt<'_>,
  ty: Type,
  mut generics: Vec<TypeWithKind>,
- _cache: &Cache,
  ) {
  let is_full_generic = ty.is_full_generic();
 
@@ -350,32 +347,25 @@ crate fn get_real_types<'tcx>(
  for param_def in poly_trait.generic_params.iter() {
  match &param_def.kind {
  clean::GenericParamDefKind::Type { default: Some(ty), .. } => {
- get_real_types(
- generics,
- ty,
- tcx,
- recurse + 1,
- &mut ty_generics,
- cache,
- )
+ get_real_types(generics, ty, tcx, recurse + 1, &mut ty_generics)
  }
  _ => {}
  }
  }
  }
  }
- insert_ty(res, tcx, arg.clone(), ty_generics, cache);
+ insert_ty(res, tcx, arg.clone(), ty_generics);
  }
  // Otherwise we check if the trait bounds are "inlined" like `T: Option<u32>`...
  if let Some(bound) = generics.params.iter().find(|g| g.is_type() && g.name == arg_s) {
  let mut ty_generics = Vec::new();
  for bound in bound.get_bounds().unwrap_or(&[]) {
  if let Some(path) = bound.get_trait_path() {
  let ty = Type::Path { path };
- get_real_types(generics, &ty, tcx, recurse + 1, &mut ty_generics, cache);
+ get_real_types(generics, &ty, tcx, recurse + 1, &mut ty_generics);
  }
  }
- insert_ty(res, tcx, arg.clone(), ty_generics, cache);
+ insert_ty(res, tcx, arg.clone(), ty_generics);
  }
  } else {
  // This is not a type parameter. So for example if we have `T, U: Option<T>`, and we're
@@ -386,10 +376,10 @@ crate fn get_real_types<'tcx>(
  let mut ty_generics = Vec::new();
  if let Some(arg_generics) = arg.generics() {
  for gen in arg_generics.iter() {
- get_real_types(generics, gen, tcx, recurse + 1, &mut ty_generics, cache);
+ get_real_types(generics, gen, tcx, recurse + 1, &mut ty_generics);
  }
  }
- insert_ty(res, tcx, arg.clone(), ty_generics, cache);
+ insert_ty(res, tcx, arg.clone(), ty_generics);
  }
 }
 
@@ -401,15 +391,14 @@ crate fn get_all_types<'tcx>(
  generics: &Generics,
  decl: &FnDecl,
  tcx: TyCtxt<'tcx>,
- cache: &Cache,
 ) -> (Vec<TypeWithKind>, Vec<TypeWithKind>) {
  let mut all_types = Vec::new();
  for arg in decl.inputs.values.iter() {
  if arg.type_.is_self_type() {
  continue;
  }
  let mut args = Vec::new();
- get_real_types(generics, &arg.type_, tcx, 0, &mut args, cache);
+ get_real_types(generics, &arg.type_, tcx, 0, &mut args);
  if !args.is_empty() {
  all_types.extend(args);
  } else {
@@ -423,7 +412,7 @@ crate fn get_all_types<'tcx>(
  let mut ret_types = Vec::new();
  match decl.output {
  FnRetTy::Return(ref return_type) => {
- get_real_types(generics, return_type, tcx, 0, &mut ret_types, cache);
+ get_real_types(generics, return_type, tcx, 0, &mut ret_types);
  if ret_types.is_empty() {
  if let Some(kind) =
  return_type.def_id_no_primitives().map(|did| tcx.def_kind(did).into())