build: update rules_rust 0.49.3 -> 0.54.1 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It started for me with seeing that rust_analyzer LSP does not highlight `use prost::Message;` in bazel.rs. Actually looks like the `@crates//:prost` dependency was not specified explicitly, and new version of `rules_rust` catches this issue. Build fails with below message otherwise in new `rules_rust` version if prost is not explicitly mentioned in deps: ``` error[E0432]: unresolved import `prost` --> src/bazel.rs:37:5 | 37 | use prost::Message; | ^^^^^ use of undeclared crate or module `prost` ```
hauserx
force-pushed
the
update_rules_rust
branch
from
c0cdc98 to
2fdc1a7
Compare
hauserx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started for me with seeing that rust_analyzer LSP does not highlight
use prost::Message;in bazel.rs. Actually looks like the@crates//:prostdependency was not specified explicitly, and new version ofrules_rustcatches this issue.Build fails with below message otherwise in new
rules_rustversion if prost is not explicitly mentioned in deps: