Using hermetic linux C++ toolchain. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to reproducible builds as it uses specific version of C++ compiler and glibc instead of using system ones. Under linux using the oldest supported version of glibc by Rust (2.17), this should allow user on some older platforms to use this repo right away, see e.g. cameron-martin#38, with this change the bazel-lsp binary starts in docker image centos:7 Not supporting Windows yet, it does not compile google abseil under Widows (there is prost -> protoc -> abseil dep). Bug on zig side: ziglang/zig#10989
hauserx
force-pushed
the
hermetic_toolchain
branch
from
935d96f to
6171d6e
Compare
hauserx
changed the title
cameron-martin
approved these changes
Nov 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to reproducible builds as it uses specific version of C++ compiler and glibc instead of using system ones.
Under linux using the oldest supported version of glibc by Rust (2.17), this should allow user on some older platforms to use this repo right away, see e.g. #38, with this change the bazel-lsp binary starts in docker image centos:7
Not supporting Windows yet, it does not compile google abseil under Widows (there is prost -> protoc -> abseil dep). Bug on zig side: ziglang/zig#10989
BEGIN_COMMIT_OVERRIDE
fix: Use hermetic linux C++ toolchain
END_COMMIT_OVERRIDE