Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert html to markdown in docs #66

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

hauserx
Copy link
Contributor

@hauserx hauserx commented Dec 5, 2024

Documentation for builtin starlark methods contains HTML tags, while LSP
clients handle markdown much easier. Used htmd crate to convert HTML
tags to markdown, and additionally change links from relative to
pointing to bazel website.

Fixes #65

Documentation for builtin starlark methods contains HTML tags, while LSP
clients handle markdown much easier. Used htmd crate to convert HTML
tags to markdown, and additionally change links from relative to
pointing to bazel website.

Fixes cameron-martin#65
Copy link
Owner

@cameron-martin cameron-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the extra dep, looks good, thanks!

src/builtin.rs Outdated Show resolved Hide resolved
@cameron-martin cameron-martin enabled auto-merge (squash) December 12, 2024 23:16
@cameron-martin cameron-martin merged commit bf9d1c7 into cameron-martin:master Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover documentation is truncated for some symbols
2 participants