-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Upload from URL' routes #28
Conversation
Request a review or otherwise let me know when you're ready with these two PRs :) |
@birm I think they are ready. |
Can we give the user the ability to set an auth header for the request? e.g. for google bucket |
I'm not sure that I understand. Can you elaborate a little. |
In short, add a url param (or something) that lets a user specify an Authorization header to the url. This is for when a url requires a specific auth header to access. In the simple case, let's pretend we're grabbing a slide from another camicroscope instance, then it needs an auth token for that instance. (though while camic can accept it as a urlparam, some sources may not). |
That said, if you don't want to do this now, that's fine; this is an improvement even without that functionality. |
Maybe workflow for the authorization header will be different for every service like google and any other. If it's alright then lets keep this option to deal with the links which directly(publicly) points to the file for now. |
However, just a thought; |
I'm getting a 404 on the new route (http://localhost:4010/loader/urlupload/continue/BIYBJ2HZH3). Maybe I've messed up testing. I'll look again soon with more energy. |
url has to be passed as body in the
|
Anyway even if url is not passed, 404 should not occur.🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me, I'd built the loader against the wrong pull request... Seems to work fine! Thanks for working through this!
Two new routes have been added.
One for uploading image file from the given URL.
The other for checking that whether the image upload has been completed or not (is useful for large image files or less bandwidth connection)
This is used with caMicroscope #353