Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask API typo #64

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Flask API typo #64

merged 1 commit into from
Jun 20, 2023

Conversation

CGDogan
Copy link
Contributor

@CGDogan CGDogan commented Jun 20, 2023 •
edited
Loading

When click click to download an image, I receive a 265-byte text file instead, which turned out to be:

<!doctype html>
<html lang=en>
<title>500 Internal Server Error</title>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.</p>

So I changed these to unnamed parameters as described here: https://tedboy.github.io/flask/generated/flask.send_from_directory.html

Tested, downloading does work now

birm
birm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this!

@birm birm merged commit f837890 into camicroscope:develop Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birm birm birm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGDogan @birm