Build libvips ALSO without openslide #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to have libvips without openslide. We use libvips for converting openslide-incompatible filetypes to tif so that we may view them with openslide, but having libvips from apt with openslide makes it already try to open them with openslide, so the benefit of this is small to nothing. By building it without openslide, we force imagemagick.
But this should be a second copy of libvips in our container in line with what tpan suggested - he might use libvips to process openslide output.
This change also allows us to rename a dicom file to png or jpeg and see it. This won't be the final dicom support, this rather uses conversion, but this will be used whenever a non-wsi dicom file is imported. I'm integrating this first because this is easier to handle than a separate openslide docker
Summary
Motivation
Testing
Tested and convinced that this does work to convert dicoms. I also added some tests in the docker container for maintainability.
Questions