Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libvips ALSO without openslide #66

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

CGDogan
Copy link
Contributor

@CGDogan CGDogan commented Jun 29, 2023

We'd like to have libvips without openslide. We use libvips for converting openslide-incompatible filetypes to tif so that we may view them with openslide, but having libvips from apt with openslide makes it already try to open them with openslide, so the benefit of this is small to nothing. By building it without openslide, we force imagemagick.

But this should be a second copy of libvips in our container in line with what tpan suggested - he might use libvips to process openslide output.

This change also allows us to rename a dicom file to png or jpeg and see it. This won't be the final dicom support, this rather uses conversion, but this will be used whenever a non-wsi dicom file is imported. I'm integrating this first because this is easier to handle than a separate openslide docker

Summary

Motivation

Testing

Tested and convinced that this does work to convert dicoms. I also added some tests in the docker container for maintainability.

Questions

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic functionality, and it works at least for basic workflow. I did not test dicom. Thank you!

@birm birm merged commit ac6dad3 into camicroscope:develop Jul 18, 2023
@CGDogan CGDogan deleted the patch-4 branch July 18, 2023 18:27
CGDogan added a commit to CGDogan/SlideLoader that referenced this pull request Sep 5, 2023
birm added a commit that referenced this pull request Sep 5, 2023
Revert #66 build libvips twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants