-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spyglass out of window #275
Conversation
Good, the CI linting is working. Sorry to have introduced a style guide in the middle of your PR work. You can probably auto-fix these with |
That's actually great. We really needed it. I will ping you after making changes. Thanks |
@birm config file is giving this
|
In order to have it work on CI at least, we needed to install both eslint and eslint-config-google as non-global and use that binary. That is,
|
@birm fixed the style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Opening up to @nanli-emory for comments on behavior.
The spyglass goes out of the window at all of the corners like this
This this fix it won't go out of window at the corners