Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented searching and sorting in Information dashboard #370

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 16, 2020

Description

The following changes have been made in information dashboard :

  • Implemented searching
  • Implemented sorting
  • Improved the view of the table and made it responsive
  • Removed unnecessary code like sanitize(), validateForm() functions which are not needed in information dashboard
  • Included the 'Info' option in navbar in the landing.html page (which was missing earlier)

Motivation and Context

How Has This Been Tested?

  • I have tested these features in both Chrome and Firefox, in desktop as well as mobile view.

Screencast:

info-dashboard-1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Hemansh31
Copy link
Contributor

Hemansh31 commented Apr 16, 2020

@cjchirag7 I had previously not included info button on home screen as a security measure, since only users who had access to view the slides should only have access to the information dashboard.
Also, if you want to include info button on home page, please check user authentication before displaying content.

@cjchirag7
Copy link
Contributor Author

cjchirag7 commented Apr 16, 2020

@cjchirag7 I had previously not included info button on home screen as a security measure, since only users who had access to view the slides should only have access to the information dashboard.
Also, if you want to include info button on home page, please check user authentication before displaying content.

As the 'slides' option is available to everyone in the navbar of landing page, we may also allow the 'Info' option there, as it is just displaying the information (with no post / edit / delete operations ).
And I guess, we are also checking the user login here at line 18 of info.html by calling auth_check() , similar to the slides page (If I am wrong, please correct me)

@Hemansh31
Copy link
Contributor

@cjchirag7 I am not sure that auth_check() is called, anyways you could include it if it isn't called 🙂

@birm birm self-requested a review April 16, 2020 15:51
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the info page a little easier to work with!

@birm birm merged commit 1bdf3be into camicroscope:develop Apr 16, 2020
@cjchirag7 cjchirag7 deleted the info-dashboard branch April 17, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants