Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Popup display in model and segment app #382

Merged
merged 11 commits into from
Apr 17, 2020
Merged

[Enhancement] Popup display in model and segment app #382

merged 11 commits into from
Apr 17, 2020

Conversation

amritansh22
Copy link
Contributor

Description

In model app:

  • After changing class list, instead of an alert a popup is shown.
  • UI of class change button

In segment app

  • After uploading model, a popup is shown.
  • After deleting model, instead of an alert a popup is shown.

Motivation and Context

Improves User Interface

How Has This Been Tested?

Tested in Chrome and Firefox

Screenshots (if appropriate):

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@amritansh22 amritansh22 changed the title Develop [Enhancement] Popup display in model and segment app Apr 17, 2020
@birm birm self-requested a review April 17, 2020 14:36
apps/segment/segment.js Outdated Show resolved Hide resolved
apps/segment/segment.js Outdated Show resolved Hide resolved
apps/segment/segment.js Outdated Show resolved Hide resolved
@birm birm self-requested a review April 17, 2020 17:19
@birm
Copy link
Member

birm commented Apr 17, 2020

I'm still getting an alert on model.html on changing classes. Have I missed/misunderstood something?

@amritansh22
Copy link
Contributor Author

amritansh22 commented Apr 17, 2020

@birm I had missed that. Sorry about it.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!!

@birm birm merged commit 6497407 into camicroscope:develop Apr 17, 2020
@birm birm mentioned this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants