Initial roi feature in segment app #410
Conversation
|
@birm any idea why are the tests not been triggered ? |
|
Looks like it's here https://travis-ci.org/github/camicroscope/caMicroscope/builds/697929991 |
| @@ -1178,13 +1253,13 @@ async function showInfo() { | |||
| store.get(name).onsuccess = function(e) { | |||
| inputShape = e.target.result.input_shape.slice(1, 3).join('x'); | |||
| td = row.insertCell(); | |||
| td.innerHTML = name.split('_').splice(1).join('_').slice(0, -3); | |||
| td.innerText = name.split('_').splice(1).join('_').slice(0, -3); | |||
There was a problem hiding this comment.
Thanks for addressing these kinds of things!
|
@Insiyaa I'm sorry I still can't add you as a reviewer directly. |
|
Sorry for the delay, I'll review as soon as possible |
|
Looks good. Please check for spaces around the operators, rest it looks good. |
|
@birm can you tell how to solve the html injection issue ? The input is coming from the db and not the user , so as long as the input is sanitized earlier it should be fine right ? Also as I need the html tags I can't use something like innerText . |
|
@Insiyaa can you please elaborate on what you mean by spaces around operators ? |
|
Does this work ?
|
|
I may have missed some. Will do another pass in the next PR if that's ok . |
|
Thank you for the reviews ! And sorry for the constant bugging . |
Description
Initial roi feature in the segment app .
Feature to extract roi from selected region
Other small changes :
Added progress percentage in snackbar
Typo fix
Use innerText instead of innerHTML
How Has This Been Tested?
OS : Ubuntu 20.04
Browser : Firefox
Types of changes
**What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
**Go over all the following points, and put an
xin all the boxes that apply.**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)