-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI fixes #475
UI fixes #475
Conversation
I've fixed the conflicts, just going to test to make sure I didn't mess anything up. |
apps/info.css
Outdated
} | ||
|
||
footer{ | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(worth noting, that to me at least, the copyright notice isn't at all important, certainly not enough for it to stick eternally to the user's window)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, looking into this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I have solved the problem by using flexbox css. I wrapped the content with a flex column container and justified content as 'space-between'. I hope this works fine now :)
Thanks for being so responsive to the review! |
Description
UI fixes as mentioned in #473 are as follows:
UI Fixes:
Code Changes:
footer
tag instead ofdiv
and made corresponding changes in the html and css files.Motivation and Context
**Why is this change required? What problem does it solve?
How Has This Been Tested?
**Please describe in detail how you tested your changes.
Types of changes
**What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
**Go over all the following points, and put an
x
in all the boxes that apply.**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)
Let me know how this sounds. Will make changes if needed ASAP. Thank you for reviewing!