Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes #475

Merged
merged 7 commits into from
Jan 12, 2021
Merged

UI fixes #475

merged 7 commits into from
Jan 12, 2021

Conversation

sohamsshah
Copy link
Contributor

Description

UI fixes as mentioned in #473 are as follows:

UI Fixes:

  • Footer in both pages viz. table.html and info.html are properly placed at bottom
  • The 'Slide' button used to be active in Navbar of info.html page. This has been fixed in this PR.

Code Changes:

  • All the html files in the codebase has been named in lowercase. To keep the naming convention consistent, the name of 'Info.html' has been changed to 'info.html'
  • In table.html, the CSS was written in <style> tag, while there exists a CSS file for it. So, made changes accordingly.
  • Also used 'Semantic HTML' footer tag instead of div and made corresponding changes in the html and css files.

Motivation and Context

**Why is this change required? What problem does it solve?

How Has This Been Tested?

**Please describe in detail how you tested your changes.

  • Configured Dev Environment as suggested in the Developer Guide.
  • Tested on Localhost with responsiveness check too

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Let me know how this sounds. Will make changes if needed ASAP. Thank you for reviewing!

@birm birm changed the base branch from master to develop January 11, 2021 16:02
@birm birm self-requested a review January 11, 2021 16:02
apps/Info.html Outdated Show resolved Hide resolved
@birm
Copy link
Member

birm commented Jan 11, 2021

I've fixed the conflicts, just going to test to make sure I didn't mess anything up.

apps/Info.html Outdated Show resolved Hide resolved
apps/Info.html Outdated Show resolved Hide resolved
apps/landing/landing.html Outdated Show resolved Hide resolved
apps/table.html Outdated Show resolved Hide resolved
apps/table.html Outdated Show resolved Hide resolved
apps/info.css Outdated
}

footer{
position: absolute;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having an issue with this; it does not stay at the bottom of the screen like I presume you intend, but when scrolling down, it stays fixed to the document. That is:
image
to
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(worth noting, that to me at least, the copyright notice isn't at all important, certainly not enough for it to stick eternally to the user's window)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, looking into this issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I have solved the problem by using flexbox css. I wrapped the content with a flex column container and justified content as 'space-between'. I hope this works fine now :)

@birm birm merged commit ed86493 into camicroscope:develop Jan 12, 2021
@birm
Copy link
Member

birm commented Jan 12, 2021

Thanks for being so responsive to the review!

@birm birm mentioned this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Some UI and Code fixes required on the table.html and info.html pages
3 participants