Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Reload button is not Responsive for small size devices #579

Merged
merged 2 commits into from
Mar 3, 2023
Merged

The Reload button is not Responsive for small size devices #579

merged 2 commits into from
Mar 3, 2023

Conversation

Techkrish1
Copy link
Contributor

On the slide page, The reload button is not responsive. The button's right edges are cut into small devices. It also makes less Ui. so I fixed the issue.

issue no #578

…right edges are cut into small devices. It also makes less Ui. So, I fixxed the issue
@birm birm changed the base branch from master to develop March 1, 2023 02:44
@Techkrish1
Copy link
Contributor Author

Techkrish1 commented Mar 1, 2023

Hello Mr. Ryan sir.
Could you please check my pull request?

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! In the future I might recommend screenshots of visual changes, but this is pretty low stakes, so I'm happy to approve this.

Also, just a open source quality of life improvement, but I'd recommend working on topic branches off of your fork, and keeping your master/develop up to date with the upstream repositories. There's a guide to triangle workflows which may or may not be helpful.

@birm birm merged commit c1652df into camicroscope:develop Mar 3, 2023
@Techkrish1
Copy link
Contributor Author

Thank you so much. It is motivating me to contribute to this caMicroscope Open Source Project.

This was referenced Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants