Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve overflow issue, apply Bootstrap styling, optimize performance, and clean up code #936

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

Lochipi
Copy link
Contributor

@Lochipi Lochipi commented Mar 31, 2024

Summary

I have resolved the overflow issue in cards, applied Bootstrap styling, improved performance by moving scripts, and conducted code cleanup.

snip

before
image

After

image

Motivation

The motivation behind this was to address UI overflow problem, enhance styling consistency, optimize page load performance, and improve code maintainability.

Video demo

Recording.5.mp4

Testing

I have tested for responsive behavior and script execution, ensuring no adverse effects on performance.

Questions

None.

@Lochipi
Copy link
Contributor Author

Lochipi commented Mar 31, 2024

Hey @birm, please review this PR and let me know if any corrections are needed.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you! This also complements some other PRs on this page well.

@birm birm merged commit f15f334 into camicroscope:develop Apr 1, 2024
@Lochipi
Copy link
Contributor Author

Lochipi commented Apr 1, 2024

Great, appreciate it. You can also take a look at this one and let me know what you think @birm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants