-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Add camino::absolute() #94
Comments
Thanks for the suggestion! "absolute" can mean several things depending on the context. The closest thing currently supported is In general camino follows Rust's |
I now see I didn't mention the standard Rust API. I meant to follow's Rust's std::path::absolute, without inventing any new API. Does that seem like a good idea? |
Oh, gotcha! Yeah that makes sense then. |
Note that we take `AsRef<Path>`, not `AsRef<Utf8Path>`, for the reason mentioned in the comment. Closes camino-rs#94.
Note that we take `AsRef<Path>`, not `AsRef<Utf8Path>`, for the reason mentioned in the comment. Closes camino-rs#94.
This is now out in camino 1.1.9. Thanks for the issue! |
Ohhh I just noticed this, sorry! I'd love a future contribution from you if you ever have an idea. Thanks! |
Thanks! Really no problem, it would surely have taken longer if I had tried to implement it. For example, I wouldn't have thought of adding the Rust version check. So thanks for adding this so quickly! |
Currently in order to get the absolute path of a Utf8Path, it seems that I need to do:
How about adding an
absolute()
function to camino?I'll be happy to try to write a PR if you approve of the idea.
Thanks!
Noam
The text was updated successfully, but these errors were encountered: