Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Culture Info #15

Closed
ereznassimi opened this issue Mar 22, 2016 · 2 comments
Closed

Configurable Culture Info #15

ereznassimi opened this issue Mar 22, 2016 · 2 comments

Comments

@ereznassimi
Copy link

I have noticed the following line of code in CloudWatchAppender/CloudWatchAppender/Services/CloudWatchClientWrapperBase.cs line 127:

Thread.CurrentThread.CurrentCulture = new CultureInfo("en-GB", false);

Can you make it a configurable parameter?

Thank you!

@camitz
Copy link
Owner

camitz commented Mar 22, 2016

For what purpose? I think it's a work-around for a bug in the aws-lib
that's been fixed. I think a better idea is to remove it completely.

On Tue, Mar 22, 2016 at 4:42 PM, ereznassimi notifications@github.com
wrote:

I have noticed the following line of code in
CloudWatchAppender/CloudWatchAppender/Services/CloudWatchClientWrapperBase.cs
line 127:

Thread.CurrentThread.CurrentCulture = new CultureInfo("en-GB", false);

Can you make it a configurable parameter?

Thank you!


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#15

@ereznassimi
Copy link
Author

OK. I assumed that it has impact on component. If it can be removed, then definitely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants