Build c2cgeoportal using Docker multistage build #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
multistage-build
branch
from
5fcc696
to
1ae389b
Compare
sbrunner
force-pushed
the
multistage-build
branch
from
1ae389b
to
c7ef83f
Compare
There was a problem hiding this comment.
This is a huge pull request, difficult to review, but it seems a good move, more code removed than added :-)
It seems simpler to use, I see changes in documentation, but I do not see changes in c2cgeoportal development documentation. I would like the documentation for developers up to date with the new build system.
sbrunner
force-pushed
the
multistage-build
branch
from
b725be1
to
97ce02b
Compare
sbrunner
force-pushed
the
multistage-build
branch
from
97ce02b
to
5ee91c5
Compare
pvalsecc
reviewed
Jun 3, 2019
| @@ -0,0 +1,179 @@ | |||
| FROM camptocamp/c2cwsgiutils:2 AS base | |||
There was a problem hiding this comment.
+1 in another pull request :-)
sbrunner
force-pushed
the
multistage-build
branch
from
5ee91c5
to
c8b1771
Compare
fredj
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=> Remove the docker-run and docker-compose-run, move to Circle CI
Update the documentation
Update C2cupgrade messages
Update Docker containers diagrams
Reactivate call to updatepo
Reactivate clean DockerHub tags
I steel fave to fix the deployments