Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration info in the oeedit doc #5163

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Add configuration info in the oeedit doc #5163

merged 1 commit into from
Jul 23, 2019

Conversation

eleu
Copy link
Member

@eleu eleu commented Jul 19, 2019

Esp. for configuring the triangle size.

sbrunner
sbrunner approved these changes Jul 19, 2019
View reviewed changes
doc/integrator/object_editing.rst Outdated Show resolved Hide resolved
@eleu
Copy link
Member Author

eleu commented Jul 19, 2019 •
edited by sbrunner
Loading

some other parts need actually correction:

.. code:: yaml
     constants:
       <<: *constants
       gmfObjectEditingToolsOptions:
         regularPolygonRadius: 150

@eleu
Copy link
Member Author

eleu commented Jul 19, 2019

thanks, looks good @sbrunner

@sbrunner sbrunner requested a review from jwkaltz July 19, 2019 12:37
jwkaltz
jwkaltz approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jwkaltz jwkaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for improvement

doc/integrator/object_editing.rst
* Available as WFS layer
* Metadata "copyable" (checked) set on the layer

Add the following configuration int the ``vars.yaml`` file to change the triangle size:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"int the" -> "in the"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the triangle size -> the size of the triangle
(alternatively: the triangle's size)

doc/integrator/object_editing.rst Show resolved Hide resolved
@sbrunner
Copy link
Member

@jwkaltz I'm on holiday, then can you do the modifications and merge it?

@jwkaltz jwkaltz merged commit 7b143b6 into 2.3 Jul 23, 2019
@jwkaltz jwkaltz deleted the oeedit-doc branch July 23, 2019 12:31
@sbrunner sbrunner added this to the 2.3 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@jwkaltz jwkaltz jwkaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@eleu @sbrunner @jwkaltz