Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update-po doesn't use PGSCHEMA defined in .env file #7039

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix: update-po doesn't use PGSCHEMA defined in .env file #7039

merged 1 commit into from
Oct 6, 2020

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Sep 29, 2020 •
edited
Loading

Fix GSGMF-1395

The PGSCHEMA should come from the Docker image for the geoportal service and from the .env for the tools service...

arnaud-morvan
arnaud-morvan reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment •
edited by sbrunner
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is is not possible to add "- PGSCHEMA" in geoportal (in env alias).
  2. It would make sense, if we set a PGSCHEMA in .env to use it also for geoportal.

@sbrunner
Copy link
Member Author

  1. no: Merging sequences (like Merge keys for mappings) yaml/yaml#48
  2. I don't like it because if the image isn't done correctly we will have an issue when we will push the project to OpenShift...

@sbrunner sbrunner force-pushed the fix-pgschema-updatepo branch from 8b61ed0 to 32658dc Compare September 30, 2020 07:42
@sbrunner
Copy link
Member Author

This solution doesn't work, I propose a new solution...

@sbrunner sbrunner force-pushed the fix-pgschema-updatepo branch from 32658dc to 6988510 Compare September 30, 2020 07:43
@sbrunner sbrunner requested a review from arnaud-morvan October 6, 2020 12:29
@sbrunner sbrunner merged commit 8b47f85 into master Oct 6, 2020
@sbrunner sbrunner deleted the fix-pgschema-updatepo branch October 6, 2020 15:41
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan