Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Vary on Cookie for private query #9951

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add missing Vary on Cookie for private query #9951

merged 1 commit into from
Aug 15, 2022

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 9, 2022 •
edited
Loading

Fix: GSGMF-1888

@sbrunner sbrunner force-pushed the add-missins-cookie-vary-gsgmf-1888 branch 5 times, most recently from da42a8b to 43062bd Compare August 11, 2022 12:44
@sbrunner sbrunner marked this pull request as ready for review August 11, 2022 12:45
@sbrunner
Copy link
Member Author

@arnaud-morvan can you test it on your host?

arnaud-morvan
arnaud-morvan approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complicated to test locally.

I tested with Firefox, with additionnal host in /etc/hosts + adding allowed referer and increasing max-age to 100 and everything works as expected.

I did not manage to reproduce with Chrome and local demo.

geoportal/c2cgeoportal_geoportal/lib/caching.py Outdated Show resolved Hide resolved
geoportal/c2cgeoportal_geoportal/lib/caching.py Outdated Show resolved Hide resolved
@sbrunner sbrunner force-pushed the add-missins-cookie-vary-gsgmf-1888 branch 7 times, most recently from 9b71dda to fea8a38 Compare August 13, 2022 15:05
@sbrunner sbrunner force-pushed the add-missins-cookie-vary-gsgmf-1888 branch from fea8a38 to 48d1375 Compare August 13, 2022 15:57
@sbrunner sbrunner merged commit ce6f4f3 into 2.7 Aug 15, 2022
@sbrunner sbrunner deleted the add-missins-cookie-vary-gsgmf-1888 branch August 15, 2022 12:31
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
backport master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan