Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the dependency #1945

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Reorganize the dependency #1945

merged 2 commits into from
Sep 8, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Sep 6, 2023 •
edited
Loading

Put some dependency as not optional

@sbrunner sbrunner changed the title Less standard dependency Reorganize the dependency Sep 7, 2023
@sbrunner sbrunner marked this pull request as ready for review September 7, 2023 08:42
arnaud-morvan
arnaud-morvan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust you

@sbrunner sbrunner merged commit 12525d5 into master Sep 8, 2023
@sbrunner sbrunner deleted the dependency branch September 8, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

@gberaudo gberaudo Awaiting requested review from gberaudo

@vuilleumierc vuilleumierc Awaiting requested review from vuilleumierc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan