Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart)!: major update of dependencies on traefik chart #60

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

github-actions[bot]
Copy link
Contributor

🤖 I have updated the chart beep boop

Description of the changes

This PR updates the dependencies of the traefik Helm chart. .

⚠️ This was a major update! Please check the changelog of the updated dependencies and take notice of any breaking changes before merging. ⚠️

@github-actions github-actions bot requested a review from a team as a code owner October 24, 2023 07:06
@github-actions github-actions bot force-pushed the chart-autoupdate-major-traefik branch 6 times, most recently from 0ea832f to 52209e2 Compare November 1, 2023 07:06
@github-actions github-actions bot force-pushed the chart-autoupdate-major-traefik branch from 52209e2 to 8dd1869 Compare November 2, 2023 07:06
@lentidas lentidas self-assigned this Nov 2, 2023
@lentidas
Copy link
Contributor

lentidas commented Nov 2, 2023

The changelog lists this 2 breaking changes:

  1. On redirectTo, ports.web.redirectTo=websecure => ports.web.redirectTo.port=websecure. More details in PR feat: 💥 support http redirections and http challenges with cert-manager traefik/traefik-helm-chart#934
  2. On gateway, all values are now flattened to experimental.kubernetesGateway. More details in PR feat: 💥 rework and allow update of namespace policy for Gateway traefik/traefik-helm-chart#927

These changes do not affect our code on the module itself, but I'm aware that we set the redirection of HTTP to HTTPS traffic in some of our deployments (see point 1 above), so we need to adapt the code accordingly.

@lentidas
Copy link
Contributor

lentidas commented Nov 2, 2023

Tested an upgrade in-place without any issues.

@lentidas
Copy link
Contributor

lentidas commented Nov 2, 2023

Another note: I noticed on the v25.0.0 changelog that they removed the traefik.container.us CRDs and then they put them back again. So, we probably should update our modules that use the old group before the next release, as they might remove it then.

@lentidas lentidas merged commit 915831e into main Nov 2, 2023
@lentidas lentidas deleted the chart-autoupdate-major-traefik branch November 2, 2023 16:06
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant