Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to filter the environment variables #180

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Add ability to filter the environment variables #180

merged 1 commit into from
Aug 10, 2021

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 9, 2021

No description provided.

@sbrunner sbrunner requested a review from danduk82 August 9, 2021 13:04
@sbrunner sbrunner added backport 3.10 backport 3.16 Backport the pull request to the '3.16' branch and removed backport 3.4 backport 3.16 Backport the pull request to the '3.16' branch labels Aug 9, 2021
danduk82
danduk82 requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@danduk82 danduk82 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I was wondering if instead of passing the whole environment, and filtering out some stuff, if we shouldn't instead whitelist the passEnv environment variables that are really useful and write them directly to a config file.

@sbrunner
Copy link
Member Author

Personally, I prefer not to introduce to read a config file in bash...

@danduk82
Copy link
Member

mmh, why read it? just write the FCGI config file in the image and that's it.

@sbrunner
Copy link
Member Author

No, it's not so simple, we also find a way to build this file, and to give it to the container, for me, it's to complicate to integrate...

danduk82
danduk82 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@danduk82 danduk82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbrunner sbrunner merged commit 2adc525 into master Aug 10, 2021
@sbrunner sbrunner deleted the filter-env branch August 10, 2021 06:52
This was referenced Aug 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danduk82 danduk82 danduk82 approved these changes

Assignees
No one assigned
Labels
backport 3.16 Backport the pull request to the '3.16' branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @danduk82