Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub - do not show catalog name anymore #18

Merged
merged 1 commit into from
May 29, 2024

Conversation

rcaplier
Copy link
Contributor

@rcaplier rcaplier commented May 29, 2024

Description

This PR removed the catalog name from the dataset page.

Screenshots

Before :

image

After :

Screenshot from 2024-05-29 09-24-26

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Swisstopo.

@rcaplier rcaplier self-assigned this May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@rcaplier rcaplier force-pushed the geocat-do-not-show-catalog-name-anymore branch from 9331266 to 9897fbf Compare May 29, 2024 07:46
Copy link
Contributor

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM. I know there's an issue with the e2e but might be worth making them run anyway to check if your changes don't break anything else (since we know the issue is located on the API form only) 🙂

@rcaplier rcaplier merged commit 68de0b7 into geocat May 29, 2024
5 checks passed
@rcaplier rcaplier deleted the geocat-do-not-show-catalog-name-anymore branch May 29, 2024 13:28
fgravin pushed a commit that referenced this pull request Jun 4, 2024
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
fgravin pushed a commit that referenced this pull request Jun 12, 2024
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
fgravin pushed a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants