Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation on secrets filenames is a poor UX #8

Closed
tyrken opened this issue Oct 28, 2020 · 2 comments
Closed

Limitation on secrets filenames is a poor UX #8

tyrken opened this issue Oct 28, 2020 · 2 comments

Comments

@tyrken
Copy link

tyrken commented Oct 28, 2020

The secrets*.yaml type naming restriction is a bit awkward - it's a bad user experience that has tripped me up a few times even when I knew it existed. It misses out on matching .yml files or secret-things.yaml, and at least some more recent forks of the plugin (e.g. https://github.com/jkroepke/helm-secrets that I use) have no such restriction - so helm secrets xxx works and helm-sops doesn't.

Can you not peek at every values-file in the argument list, and see if they contain a valid-looking sops/version key so its likely it's a sops file?

This was also requested on the original futuresimple version, see zendesk/helm-secrets#155.

@yann-soubeyrand
Copy link
Member

Could be great, indeed! PR welcome ;-)

teejaded added a commit to teejaded/helm-sops that referenced this issue Nov 3, 2020
hbollon pushed a commit to teejaded/helm-sops that referenced this issue Jun 21, 2023
hbollon pushed a commit that referenced this issue Jun 23, 2023
@hbollon
Copy link
Member

hbollon commented Jun 23, 2023

Fixed in #9 which is now released 🎉

@hbollon hbollon closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants