Add getCollectionItemsUrl Method for OGC API #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronitjadhav
force-pushed
the
ogcapi-collection-item-url
branch
from
9cb08ec
to
863a979
Compare
jahow
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks! I think it looks good, there's a few parameters that are not supported in there though. In the future we might want to read what the endpoint advertises as supported (e.g. crs, formats...) to make sure the request is valid, but for now this is good :)
ronitjadhav
force-pushed
the
ogcapi-collection-item-url
branch
from
186b246
to
92899f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
getCollectionItemsUrlmethod in theOgcApiEndpointclass. This method is designed to generate a URL for the items of a specified collection, with optional query parameters.The parameters include query, outputFormat, maxFeatures, skipGeometry, offset, outputCrs, extent, extentCrs, and properties. The method returns a promise that resolves to the URL as a string or rejects if an error occurs.
In addition to the method, this PR also includes unit tests to ensure the correct functionality of the
getCollectionItemsUrlmethod.This addition enhances the functionality of the
OgcApiEndpointclass, providing more flexibility and options for users when working with collection items.