Use self-reported operation URLs from capability documents #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
approved these changes
Oct 25, 2024
|
This will be merged as soon as it is rebased, thanks! |
WMS Capabilities documents self-report the URLs to be used for operations. These self-reported URLs should be used rather than the URL used to retrieve the capabiliites.
Due to the mocking of the async loading of the capabilities the loading occurs instantaneously and the state before they are loaded is not tested correctly
WFS Capabilities documents self-report the URLs to be used for operations. These self-reported URLs should be used rather than the URL used to retrieve the capabiliites.
Due to the mocking of the async loading of the capabilities the loading occurs instantaneously and the state before they are loaded is not tested correctly
ejn
force-pushed
the
feature-service-urls
branch
from
e28b815
to
0dd1079
Compare
|
@jahow Thank you for the positive review! I have rebased onto the current state of |
|
All good, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OWS Capability documents include definitions of the URLs to be used for all operations. As a general rule these are (i) all the same and (ii) the same as the URL from which the capabilities document was retrieved. This is however not necessarily the case, e.g. where request forwarding has occured. Formally, these self-reported URLs should be used for all operations.
This PR therefore exposes the self-reported operation URLs in the API and also uses these as the base for generated request URLs.
Notes: