7.0 binary field swift #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaunier
reviewed
Oct 25, 2019
| @@ -271,23 +271,6 @@ def _fnct_write(self, obj, cr, uid, ids, field_name, value, args, | |||
| obj, cr, uid, ids, name, context=context) | |||
| return True | |||
|
|
|||
| def _read_binary(self, storage, record, field_name, binary_uid, | |||
There was a problem hiding this comment.
Could you explain (in the PR description?) why you remove this function?
Else it is hard for reviewers to figure out if this makes sense :)
Edit: OK I had not paid attention to the commit title. But more explanations are never too much :)
guewen
pushed a commit
that referenced
this pull request
Jul 15, 2020
Add a couple of cosmetic improvements
damdam-s
added a commit
that referenced
this pull request
May 3, 2022
fix(database_cleanup): endless loop
StephaneMangin
pushed a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.