Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple instances of the same resource #115

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

Wiston999
Copy link
Contributor

Changes proposed to fix #97.

It adds support for multiple resources created under the same type and name. This is the use case when count or for_each are used.

Additionally:

  • Modify state representation to add resource index
    image
  • Modify search table to add resource type and resource index under "Resource ID" column
    image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 15.541% when pulling ead7125 on Wiston999:for-each-resources into a7ada9f on camptocamp:master.

Copy link
Contributor

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@raphink raphink merged commit 5906197 into camptocamp:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources created using for_each are missing
3 participants