Implement AWS EXTERNAL ID feature #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphink
reviewed
Feb 23, 2021
state/aws.go
Outdated
| @@ -35,7 +35,9 @@ func NewAWS(c *config.Config) AWS { | |||
|
|
|||
| if len(c.AWS.APPRoleArn) > 0 { | |||
| log.Debugf("Using %s role", c.AWS.APPRoleArn) | |||
| creds := stscreds.NewCredentials(sess, c.AWS.APPRoleArn) | |||
| creds := stscreds.NewCredentials(sess, c.AWS.APPRoleArn, func(p *stscreds.AssumeRoleProvider) { | |||
| p.ExternalID = aws_sdk.String(c.AWS.ExternalID) | |||
There was a problem hiding this comment.
What happens when the ExternalID is not specified? Does it behave the same as today?
There was a problem hiding this comment.
It should be the same, as the default value is always an empty string. Moreover, let me do some tests to verify it, and I will come back to you! 😄
thanks
|
Hello again, after some tests I realised it is also necessary to put an if-statement. In case Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The variable
--app-role-arnprovides the feature of assuming an AWS role during runtime. This allows the service to access services from a different account where it is running. Moreover, AWS recommends using this funcionality along with what they callexternal id. This is a random string or number the client must provide to assume an specific role. It acts like a password.https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html
This PR implements this functionality. I've added a new environment variable called
AWS_EXTERNAL_ID, a new CLI option--aws-external-idand a new YAML parameter:aws.external-id.If the value is not provided, it will use the default value in a Go string (an empty string
""), so it should work always.Regards,