Improve search engine #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphink
suggested changes
Aug 1, 2017
static/terraboard.js
Outdated
| @@ -312,6 +324,27 @@ app.controller("tbSearchCtrl", ['$scope', '$http', '$location', '$routeParams', | |||
| $scope.attrKey = undefined; | |||
| $scope.attrVal = undefined; | |||
| $scope.results = undefined; | |||
| $scope.doSearch(1); | |||
| $location.url('/search'); | |||
There was a problem hiding this comment.
Two comments here:
- absolute URLs break with the base href, only use relative URLs;
- why not use
$location.search()instead?
static/terraboard.js
Outdated
| params.page = page; | ||
| } | ||
| var query = $.param(params); | ||
| $location.url('/search?'+query); |
There was a problem hiding this comment.
Again, do not use absolute URLs here.
There was a problem hiding this comment.
On my screen, the fields are a bit on top of each other for some reason
cryptobioz
force-pushed
the
search-engine
branch
from
f4a391e to
1900451
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix design bugs and add the possibility to create permalinks.