do not require importing bolero_generator or TypeGenerator in order to derive #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog
force-pushed
the
no-require-import
branch
from
9f89151 to
2f8a238
Compare
camshaft
approved these changes
Jan 9, 2023
| @@ -14,6 +14,7 @@ readme = "../bolero-generator/README.md" | |||
| proc-macro = true | |||
|
|
|||
| [dependencies] | |||
| proc-macro-crate = "1.2" | |||
There was a problem hiding this comment.
I looked at how this works; quite the hack! But I'm not sure how else to accomplish it.
There was a problem hiding this comment.
Yeah, unfortunately I think this won't be improved upon until there's a real story around proc-macro hygiene at least (or maybe more), and even that is already pretty far away :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
This works with both imports from bolero::generator and bolero_generator, while before people had to imperatively import from bolero_generator and explicitly use TypeGenerator.