Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make with_iterations and with_max_len actually usable #186

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Ekleog-NEAR
Copy link
Contributor

I tried using with_iterations, and came across the issue that bolero::check!() is not actually a RngEngine, hence making it impossible to actually use it from a test.

This fixes it. With these changes, the priority of settings now is:

  • Highest-priority, the environment variable (as it’s runtime-configured)
  • Lower priority, the .with_iterations() setting (as it’s build-time configured)
  • Lowest priority, the 1000/25 default (as it’s hard-coded)

@camshaft
Copy link
Owner

Nice catch! thanks!

@camshaft camshaft merged commit f0d4332 into camshaft:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants