deprecate driver mode #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
deprecate-driver-mode
branch
from
489722a to
0967772
Compare
camshaft
force-pushed
the
deprecate-driver-mode
branch
from
0967772 to
56a1415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, DriverMode was designed to give various drivers options for how to generate values, either in Forced mode, which basically tries everything it can to generate a valid value, or
Directmode, which maps the underlying bytes directly to a value and bails if not possible. In practice, DriverMode is confusing, inconsistent, and poorly documented.This change deprecates the use of
DriverModeand instead just uses a combination of the two in places where it makes sense. Essentially, the way generators are implemented no longer depend on the driver type itself.