Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky side-panel for favorites & markdown-outline #15

Merged
merged 3 commits into from
Apr 3, 2016

Conversation

zbycz
Copy link
Contributor

@zbycz zbycz commented Apr 2, 2016

Hi,

I really often needed to switch several repositories on github, and opening bookmarks seemed unhandy. So i thought it would be cool to add favorites in a fixed-position sidebar. Then I also wanted to quickly jump around markdown documents, so I added @dbkaplun's github-markdown-outline-extension (MIT License) also to the panel. Which is kind of handy - because you see it fixed-position all the time.

Here is the result:
screen shot 2016-04-02 at 10 15 32

Also on that small screen the panel auto-hides, on bigger screen remains open. And when the outline is too big, another independent scrollbar is shown.

The code is kind of crappy - I just coded it as quickly as I could :-) Still I`d be happy to merge to main master.. Otherwise please tell me what to change.

@camsong
Copy link
Owner

camsong commented Apr 3, 2016

Great @zbycz, I definitely like this. I'll merge this PR first and release soon after tweak the code.

@camsong camsong merged commit 0bea955 into camsong:master Apr 3, 2016
@zbycz
Copy link
Contributor Author

zbycz commented Apr 3, 2016

Thank you, Cam! Will be happy to see it out.

@camsong
Copy link
Owner

camsong commented Apr 4, 2016

@zbycz
Copy link
Contributor Author

zbycz commented Apr 4, 2016

Great! Two more things:

  1. Maybe add the screenshot in the main README.md?
  2. Unluckily - sticky panel gets under sticky issue sidebar - needs: z-index: 30; instead of 10
    screen shot 2016-04-04 at 17 38 59

@camsong
Copy link
Owner

camsong commented Apr 5, 2016

  1. added
  2. fixed in 0.14.2

@camsong
Copy link
Owner

camsong commented Apr 5, 2016

The reason I don't like github-events-viewer as a default links is it's not easy to use right now. It requires user to input token, which is not easy for most users. If you can make it better looking and not show all events data inside the page, not through a new tab, I would like to add it back

@zbycz
Copy link
Contributor Author

zbycz commented Apr 5, 2016

  1. Well, user token is very easy - just beside the input, there is a link where user clicks two times. I dont see it difficult.
  2. Although I see a security concern - the page could be hacked to give out the token. A solution could be to use cdn version which is cached forever, so nobody nor I could tamper with it.
  3. Design is little "uncool".. I take it as the only valid argument :-)
  4. why not showing the events data in the page? thats the purpose :-)

[continuing discussion from commit]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants