-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipped timepoint predictions, improvements to Ridership #19
Conversation
…when created. Not intended use.
…sing flag when creating tripDetails
I believe it was unnecessary anyway.
This is a timely pull request :). There is a discussion on the google/transit repo debating whether consumers should propagate Two questions:
|
Hi Sean,
|
Thanks @sheldonabrown! So if you had the following Stops with real-time info:
...and a Stop C following this, but with no real-time data, would |
@sheldonabrown Friendly ping on above question on whether delays are propagated through |
@NJBL or @sheldonabrown Could you please clarify on whether delays are propagated through |
|
||
if (tpr.isSkipped()) { | ||
_log.debug("Skipped Stop: " + instance.getStop().getId().getId()); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NJBL @sheldonabrown I just called for a vote on google/transit#139, which is an official proposal for the GTFS-realtime spec that clarifies that delays should be propagated over SKIPPED stops, which is Google's implementation. It's been a long time since I've dived into this code in OBA, but I think this may need to be changed to a continue
instead of break
(and counters properly incremented) to propagate delays past the SKIPPED stop? IIRC this break
would result in scheduled times showing up after the SKIPPED
stop (i.e., no real-time info).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NJBL @sheldonabrown google/transit#139 is now approved and part of the GTFS-rt spec. Can you please confirm whether OBA follows this behavior or not?
Added functionality: Handling StopTimeUpdates that have Skipped Schedule Relationships.
Also, handling TripUpdates that have Cancelled Scheduled Relationships more effectively.
Changed the response for Ridership Information to be clearer. Included service date filtering option when using the Ridership Service.