Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/condition defaultvaluechange #182

Conversation

amardeep2006
Copy link

Camunda Community Hub Pull Request Template

Description

The Notification service is enabled by default in Spring boot starter. It should be enabled only once we set folowing propertiess as true.

       camunda.bpm.plugin.mail.notification.enabled: true
       camunda.bpm.plugin.mail.mail.notification.enabled: true

Additional context

We are using this plugin in Our organization's Internal Camunda Starter and noticed that if do not supply below properties in child projects the It tries to start the Mail service and fails and compalins about missing mail properties.

       camunda.bpm.plugin.mail.notification.enabled: true
       camunda.bpm.plugin.mail.mail.notification.enabled: true

Testing your changes

Existing test case have been modified to include the properties in Application.yml files.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@jonathanlukas
Copy link
Collaborator

I will not invert the default behaviour of this flag as it is documented here: https://github.com/camunda-community-hub/camunda-platform-7-mail/tree/main/extension/spring-boot#special-configuration-properties

Also, the reason why both properties are mapped is to remain compatible with a copy-pasted properties config from the core package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants